feat: add ability to login with a Personal access token #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tgly307
commented
Jul 31, 2018
tgly307
commented
- Add ability to login with a Personal access token
- Remove useless attribute "info" of MattermostClient, its value is same with "user" and no place use it.
- The default value of "data" which in post function of MattermostAPI is removed, because the "data" field is not optional, and the type of json.dumps(None) is string, an error will be reported.
# Conflicts: # mmpy_bot/mattermost_v4.py
…attribute 'info' of MattermostClient. Modify data of post function in MattermostAPI from optional to required.
|
#51 done |
attzonko
reviewed
Jul 31, 2018
mmpy_bot/mattermost.py
Outdated
| self.user = None | ||
| self.info = None | ||
| # self.info = None |
There was a problem hiding this comment.
If you are getting rid of info, might as well delete these lines instead of commenting them out.
attzonko
reviewed
Jul 31, 2018
mmpy_bot/mattermost.py
Outdated
| self.login(team, email, password) | ||
|
|
||
| def login(self, team, email, password): | ||
| self.email = email | ||
| self.user = self.api.login(team, email, password) | ||
| self.info = self.api.me() | ||
| # self.info = self.api.me() |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.