fix error when handle bad command. #49
Conversation
# Conflicts: # mmpy_bot/mattermost_v4.py
|
Code Climate has analyzed commit 1f26132 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.5% (0.0% change). View more on Code Climate. |
|
Thanks for finding and fixing this. Is there some test we can add to catch stuff like this in the future? |
|
In fact, I am not good at writing test cases, I feel that the existing test cases are comprehensive enough. Perhaps due to the historical reasons of this project, some code is still in a stage that is not fully understood, and we can gradually comb the old code to add unit tests. After all, this project does not exist as commercial software, we can slowly find the problem. XD |
|
Totally agree, was just wondering if this issue might be an easy one to add a test case for, and since you hit it and fixed it you might be the best to answer that question. I'll have to think more about your Python version question. I was hoping that we can continue to support both, meaning to be backwards compatible if possible. |
|
@tgly307 Could you share us more how you bumped into this error ? There might be clue for constructing adequate test cases. |
|
@seLain I want to modify default response content, before I start this work, I tried to entered a wrong command to see how this function work. |
|
@attzonko OK, got it. But the execfile() function is not support in python 3, although this code will rarely execute，I think it needs to be version compatible here to avoid error like this issue . |
No description provided.