Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against a mattermost instance running in docker #129 #150

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Run tests against a mattermost instance running in docker #129 #150

merged 1 commit into from
Feb 17, 2021

Conversation

rwky
Copy link
Contributor

@rwky rwky commented Feb 17, 2021

  • Run tests in using a docker mattermost container in travis
  • Added script tests/run-tests-in-docker.sh to run tests in docker locally
  • Removed testing on EOL python versions
  • Fixed tests/behavior_tests/test_conversation.py test where mattermost
    no longer highlights a user if there is no space after the @username
  • Fixed tests throwing an error when invalid JSON is returned from the
    websocket
  • Added docs for running tests in docker locally

Closes #136

@rwky
Run tests against a mattermost instance running in docker
fa505b1 
* Run tests in using a docker mattermost container in travis
* Added script tests/run-tests-in-docker.sh to run tests in docker locally
* Removed testing on EOL python versions
* Fixed tests/behavior_tests/test_conversation.py test where mattermost
  no longer highlights a user if there is no space after the @username
* Fixed tests throwing an error when invalid JSON is returned from the
  websocket
* Added docs for running tests in docker locally

attzonko#129
@codeclimate
Copy link

codeclimate bot commented Feb 17, 2021

Code Climate has analyzed commit fa505b1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.6%.

View more on Code Climate.

@rwky rwky mentioned this pull request Feb 17, 2021
Closed
attzonko
attzonko approved these changes Feb 17, 2021
View reviewed changes
Copy link
Owner

@attzonko attzonko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR. This is a much-needed push in the right direction. Glad to see Travis finally has something newer than trusty distro to use. And our build badge is finally green again! You rock!

@attzonko attzonko merged commit 3251882 into attzonko:master Feb 17, 2021
@rwky
Copy link
Contributor Author

rwky commented Feb 17, 2021

Thank you so much for this PR. This is a much-needed push in the right direction. Glad to see Travis finally has something newer than trusty distro to use. And our build badge is finally green again! You rock!

Happy to help!

Travis supports bionic and focal as well. Xenial is the default at the moment but as the default changes it'll automatically switch. I doubt any upgrades will break anything so we should be good for a long time :) you can always mention me in an issue if it does break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attzonko attzonko attzonko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwky @attzonko