Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases #13

Merged
merged 4 commits into from
Feb 24, 2018
Merged

Add test cases #13

merged 4 commits into from
Feb 24, 2018

Conversation

seLain
Copy link
Collaborator

@seLain seLain commented Feb 24, 2018

  • Built by reusing test design of slackbot.
  • Run by PyTest
  • Instructions to run the tests were added to README

@seLain seLain added the enhancement New feature or request label Feb 24, 2018
@seLain seLain merged commit a55791b into attzonko:master Feb 24, 2018
@seLain
Copy link
Collaborator Author

seLain commented Feb 24, 2018

@attzonko I accidentally pushed and merged this PR before all Codacy issues resolved. And it seems I can not revert this merge.

I think these unsolved issues should be just fine for the tests module. Please help me review it, or maybe revert this merge ? Thanks !

@attzonko
Copy link
Owner

I think we should be fine. We can fix codacy issues in subsequent commits.

@attzonko
Copy link
Owner

Thanks for working on this.

attzonko pushed a commit that referenced this pull request Aug 12, 2018
@seLain @attzonko
Restructuring tests and doc (#13) (#60)
7b7834f 
* add some unit tests
* add behavior tests for allowed_users decorator
* move test instructions from README to docs
* reorganize unit tests
* restructuring behavior tests and doc
tgly307 referenced this pull request in tgly307/mmpy_bot Aug 16, 2018
@seLain @tgly307
Restructuring tests and doc (#13) (#60)
3e1b585 
* add some unit tests
* add behavior tests for allowed_users decorator
* move test instructions from README to docs
* reorganize unit tests
* restructuring behavior tests and doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seLain @attzonko