Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dynssz annotation for electra.Attestation #196

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

pk910
Copy link
Contributor

@pk910 pk910 commented Feb 5, 2025

Parsing electra blocks with dynssz enabled currently fails for the BeaconBlockBody.Attestations field (size mismatch).

The problem is a wrong annotation in the Attestation container.
dynssz-size shouldn't be set here as there is no ssz-size too.
The intention of that tag was probably to calculate the ssz-max tag dynamically.
The corresponding dynssz tag is called dynssz-max.

@pk910
Copy link
Contributor Author

pk910 commented Feb 5, 2025

@mcdee
ready for review :)

@mcdee mcdee merged commit 3644a22 into attestantio:master Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants