Enable malloc debug features #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables malloc debugging features provided by various implementations. This is only really useful when issue #396 is resolved so that `ksh` no longer uses the AST Vmalloc subsystem. I'm recommending merging this now to to make it obvious that any bugs involving the use of the native malloc subsystem are caught sooner rather than later.
|
P.S., I tested this on several distros such as FreeBSD11. This change makes |
|
P.P.S., This results in FreeBSD 11 test failures going from 65 to 74. So apparently there are a lot more "use after free" or "malloc buffers should be initialized to zero", or similar, bugs in the code. |
siteshwar
reviewed
Feb 8, 2018
| # | ||
| malloc_debug_env = environment() | ||
| # These env vars are recognized by GNU malloc. | ||
| malloc_debug_env.set('MALLOC_CHECK_', '3') |
There was a problem hiding this comment.
I think we should also set MALLOC_PERTURB_ environment variable here. This would set all the free'd bytes to value specified by this variable, so it's easier to detect use after free cases.
There was a problem hiding this comment.
Done. Set to 165 (0xA5) to mimic the macOS behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables malloc debugging features provided by various
implementations. This is only really useful when issue #396 is resolved
so that
kshno longer uses the AST Vmalloc subsystem. I'm recommendingmerging this now to to make it obvious that any bugs involving the use
of the native malloc subsystem are caught sooner rather than later.