nmake fails to build on FreeBSD 11.0 and 11.1

[ghost]

This is probably the wrong place to get help. I'm trying to get a recent version of ksh going so I can install CDE. When I run ./bin/package make, it gives me this error and fails compiling ast.

`mamake [cmd/nmake]: *** exit code 1 making expand.o

• nmake --base --compile '--file=/home/wfisher/ast/src/cmd/nmake/Makerules.mk'
  /bin/sh: nmake: not found
  mamake [cmd/nmake]: *** exit code 127 making Makerules.mo
  mamake: *** exit code 1 making cmd/nmake
  package: make: errors making /home/wfisher/ast/arch/freebsd11.amd64/bin/nmake`

I don't know if I'm compiling things wrong or missing a dependency but the Googles hasn't turned up any help.

Thanks!!

[saper]

(corrected)

It happens to me on 11 (11.1-PRERELEASE) but only when running bin/package flat make from the git repository; when building an updated port version I am trying to fix right now it does not happen - it fails on 11.x due to #48 instead.

[saper]

Seems to be caused by this:

+ cc -D_BLD_DLL -fPIC -D_BLD_ast -O -I. -I/home/saper/sw/ast/src/lib/libast -Icomp -I/home/saper/sw/ast/src/lib/libast/comp -Ivmalloc -I/home/saper/
sw/ast/src/lib/libast/vmalloc -Iinclude -I/home/saper/sw/ast/src/lib/libast/include -Istd -I/home/saper/sw/ast/src/lib/libast/std -D_PACKAGE_ast -c
/home/saper/sw/ast/src/lib/libast/vmalloc/vmdcshare.c
/home/saper/sw/ast/src/lib/libast/vmalloc/vmdcshare.c:187:10: error: use of undeclared identifier 'ALIGN'
        size += MMHEAD(mmdc->name) + ALIGN;
+ cc -D_BLD_DLL -fPIC -D_BLD_ast -O -I. -I/home/saper/sw/ast/src/lib/libast -Icomp -I/home/saper/sw/ast/src/lib/libast/comp -Ivmalloc -I/home/saper/
sw/ast/src/lib/libast/vmalloc -Iinclude -I/home/saper/sw/ast/src/lib/libast/include -Istd -I/home/saper/sw/ast/src/lib/libast/std -D_PACKAGE_ast -c
/home/saper/sw/ast/src/lib/libast/vmalloc/vmdcshare.c
/home/saper/sw/ast/src/lib/libast/vmalloc/vmdcshare.c:187:10: error: use of undeclared identifier 'ALIGN'
        size += MMHEAD(mmdc->name) + ALIGN;
                ^
/home/saper/sw/ast/src/lib/libast/vmalloc/vmdcshare.c:70:57: note: expanded from macro 'MMHEAD'
#define MMHEAD(name)    ROUND(sizeof(Mmvm_t)+strlen(name), ALIGN)
                                                           ^
```

[siteshwar]

I am getting this error too under FreeBSD 11.0-RELEASE-p1 :

/home/situ/ast/src/lib/libast/comp/setlocale.c:2192:88: error: use of undeclared identifier 'EILSEQ'
        if (m == (size_t)(-2) && (q->mb_errno = E2BIG) || m == (size_t)(-1) && (q->mb_errno = EILSEQ))

[saper]

Interesting, haven't seen that one at all. EILSEQ is there defined in <errno.h>, it should be there and it is included pretty late in the setlocale.c file

[siteshwar]

It was fixed by installing libiconv package.

[dannyweldon]

Was that the exact name of the package you had to install?

…

On 5 July 2017 at 04:46, Siteshwar Vashisht ***@***.***> wrote: It was fixed by install libiconv. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGgifpWDC1CXKxxNdSMz-H01uqEiL36vks5sKohzgaJpZM4LITkK> .

-- Regards Danny

[siteshwar]

Yes, the error at #26 (comment) was fixed by installing libiconv package on FreeBSD.

[saper]

lbiconv is not required, I've had it built successfully without it. Can you check your /usr/include/errno.h and see if the missing symbol is there? How did you install FreeBSD?

[siteshwar]

I installed it from this iso.

[dannyweldon]

@siteshwar What dependencies does the libiconv package have?

I think these command might work but I haven't tested them?

pkg info -d libiconv

Then check what files are in each dependant package:

pkg info -l PACKAGE

[siteshwar]

The symbol is there is /usr/include/errno.h, but it looks like it is not defined during compilation.

[saper]

@siteshwar reproduced your error: before this you get this problem:

+ cc -D_BLD_DLL -fPIC -D_BLD_ast -O -I. -I/home/saper/src/ast-beta/src/lib/libast -Icomp -I/home/saper/src/a
st-beta/src/lib/libast/comp -Iinclude -I/home/saper/src/ast-beta/src/lib/libast/include -Istd -I/home/saper/
src/ast-beta/src/lib/libast/std -D_PACKAGE_ast -c /home/saper/src/ast-beta/src/lib/libast/misc/state.c
In file included from /home/saper/src/ast-beta/src/lib/libast/misc/state.c:26:
In file included from /home/saper/src/ast-beta/src/lib/libast/include/ast.h:34:
In file included from /home/saper/src/ast-beta/src/lib/libast/include/ast_std.h:101:
In file included from ./ast_wchar.h:99:
/usr/include/../include/wchar.h:107:24: error: typedef redefinition with different types ('struct __sFILE' vs 'struct _sfio_s')
typedef struct __sFILE FILE;
                       ^
./ast_stdio.h:82:15: note: expanded from macro 'FILE'
#define FILE            _sfio_FILE
                        ^
./ast_stdio.h:80:24: note: previous definition is here
typedef struct _sfio_s _sfio_FILE;
                       ^
1 error generated.

This is fixed by a patch FreeBSD port has been applying for some time.

Another fix needed is to rename SF_* constants:

sed -i.orig -e 's|SF_FLAGS|SFIO_FLAGS|g' src/lib/libast/include/sfio*.h src/lib/libast/sfio/*.c

I don't know how to fix it in the ksh code repository without breaking SFIO API.

Other that that, you will need patches from #19 to make it build.

... and also, you will need a fix for #48 which is #50 :)

[saper]

I have pulled all the patches currently needed to build beta on FreeBSD 11 into one branch https://github.com/saper/ast/tree/beta-20170709

[krader1961]

I created a new FreeBSD 11.1 virtual machine containing the bare minimum of packages needed to compile this project. I'm getting the EILSEQ not defined build failure on FreeBSD 11.1 using gcc and clang:

/usr/home/krader/projects/3rd-party/ast/src/lib/libast/comp/setlocale.c:2192:88: error: use of undeclared identifier 'EILSEQ'
        if (m == (size_t)(-2) && (q->mb_errno = E2BIG) || m == (size_t)(-1) && (q->mb_errno = EILSEQ))

I have package libiconv-1.14_11 installed (though I did not explicitly install it). So merely installing that package is not the fix for this issue despite what has been asserted earlier in this issue.

The ./arch/freebsd11.i386-64/src/lib/libast/ast_standards.h header contains

#define _POSIX_SOURCE   1

As does the same header on macOS and Linux. That keeps /usr/include/sys/errno.h on FreeBSD from defining EILSEQ (but not on macOS or Linux):

#ifndef _POSIX_SOURCE
...
#define EILSEQ          86              /* Illegal byte sequence */
...
#endif /* _POSIX_SOURCE */

This looks like a FreeBSD bug. The EILSEQ symbol is not predicated on any symbol being defined (or not defined) on macOS or Linux. Which makes sense since the C99 standard (and POSIX AFAICT) requires it to be defined. On the other hand, the fish shell builds fine on BSD and it does not define _POSIX_SOURCE via its autotools generated configure script. So there is probably some arcane legacy issue surrounding the semantics of defining _POSIX_SOURCE that the Nmake build tools gets wrong.

Simply adding #include <errno.h> before the #include <ast_standards.h> in src/lib/libast/comp/setlocale.c "fixes" the issue and results in a working ksh binary. Obviously this requires a couple of the other changes already mentioned in this thread such as renaming SF_FLAGS to SFIO_FLAGS and adding #define _STDFILE_DECLARED to the src/lib/libast/features/wchar b/src/lib/libast/features/wchar file.

What I would like to know is why @saper isn't seeing this problem.

My inclination is to remove the explicit definition of the _POSIX_SOURCE symbol. Note that _POSIX_SOURCE has been superseded by _POSIX_C_SOURCE according to Open Group standards. But also note that _POSIX_C_SOURCE is not defined by the fish-shell project (which I contributed to until recently) so it's not clear that we should do so.

[krader1961]

Fixed by commit cbe3543.