Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous glob re-exports in hal/src/serial/mod.rs #62

Closed
michalfita opened this issue Sep 12, 2023 · 1 comment
Closed

Ambiguous glob re-exports in hal/src/serial/mod.rs #62

michalfita opened this issue Sep 12, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@michalfita
Copy link
Collaborator

Reported on CI and on my computer after rustc upgrade:

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:23:9
   |
23 | pub use uart::*;
   |         ^^^^^^^ the name `Tx` in the type namespace is first re-exported here
...
26 | pub use usart::*;
   |         -------- but the name `Tx` in the type namespace is also re-exported here
   |
   = note: `-D ambiguous-glob-reexports` implied by `-D warnings`

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:23:9
   |
23 | pub use uart::*;
   |         ^^^^^^^ the name `Rx` in the type namespace is first re-exported here
...
26 | pub use usart::*;
   |         -------- but the name `Rx` in the type namespace is also re-exported here

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:23:9
   |
23 | pub use uart::*;
   |         ^^^^^^^ the name `Uart` in the type namespace is first re-exported here
...
26 | pub use usart::*;
   |         -------- but the name `Uart` in the type namespace is also re-exported here

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:23:9
   |
23 | pub use uart::*;
   |         ^^^^^^^ the name `UartError` in the type namespace is first re-exported here
...
26 | pub use usart::*;
   |         -------- but the name `UartError` in the type namespace is also re-exported here

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:23:9
   |
23 | pub use uart::*;
   |         ^^^^^^^ the name `Event` in the type namespace is first re-exported here
...
34 | pub use spi::*;
   |         ------ but the name `Event` in the type namespace is also re-exported here

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:26:9
   |
26 | pub use usart::*;
   |         ^^^^^^^^ the name `Client` in the type namespace is first re-exported here
...
34 | pub use spi::*;
   |         ------ but the name `Client` in the type namespace is also re-exported here

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:26:9
   |
26 | pub use usart::*;
   |         ^^^^^^^^ the name `Spi` in the type namespace is first re-exported here
...
34 | pub use spi::*;
   |         ------ but the name `Spi` in the type namespace is also re-exported here

error: ambiguous glob re-exports
  --> hal/src/serial/mod.rs:26:9
   |
26 | pub use usart::*;
   |         ^^^^^^^^ the name `SpiError` in the type namespace is first re-exported here
...
34 | pub use spi::*;
   |         ------ but the name `SpiError` in the type namespace is also re-exported here

error: could not compile `atsamx7x-hal` (lib) due to 8 previous errors
Error: Process completed with exit code 101.
@martinmortsell
Copy link
Contributor

Note that these are warnings raised to errors due to the -D warnings flag set in the CI.

michalfita added a commit that referenced this issue Sep 17, 2023
michalfita added a commit that referenced this issue Oct 10, 2023
…ings

[Fixes #62] Remove re-exports to avoid warnings promoted to errors

Approved verbally by @martinmortsell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants