Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try docker dev container #449

Closed
wants to merge 1 commit into from
Closed

Try docker dev container #449

wants to merge 1 commit into from

Conversation

joepio
Copy link
Member

@joepio joepio commented Jun 15, 2022

Docker can be used to run development containers. This is especially well integrated with VSCode. This could help new developers get their dev setup up and running. No more hassle with yarn, node, cargo versions and all that - all dev tooling is included in the image.

Unfortunately, I can't seem to run cargo run in the container, as it runs out of memory during fetch:

Updating crates.io index
Killed Fetch [======>                  ]  29.46%, 1.29MiB/s    

I can see the memory limit getting closer (I provided 11GB) and the app crashes when it is reached.

But cargo run should have means to respect memory limits... What's going on here?

Maybe Hitting Container Kernel Memory Limit causes OOM on Docker Host?

PR Checklist:

  • Link to related issue
  • Add changelog entry linking to issue
  • Added tests (if needed)
  • (If new feature) added in description / readme

@AlexMikhalev
Copy link
Collaborator

Do you want me to look into it? Docker + sccache can speed up re-build. We can also put it into github workflows.

@joepio
Copy link
Member Author

joepio commented Jul 5, 2022

@AlexMikhalev If you feel like it, sure! I have no clue where to find a solution for this. Note that for me there is no direct reason to make this thing work - it's more just something I wanted to play with.

I hadn't even considered that this could speed up build times, but it makes a ton of sense.

@joepio
Copy link
Member Author

joepio commented Aug 24, 2022

I might explore this further, but for now I don't think it has serious advantages over a regular setup.

@joepio joepio closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants