This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix arm64 Linux Electron prebuild #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
See #347
Description of the Change
After merging this PR, arm64 Linux Electron prebuilds will be created in an arm64 Docker containers, which uses QEMU emulation. This seems to be the only viable option for now, because apparently node-gyp doesn't support cross-compilations for other platforms than Windows.
Alternate Designs
Possible Drawbacks
QEMU emulation is slow, thus increasing the build time. An alternative could be to use Travis arm64 hosted CI, like
sharp/sharpis doing (for x64 they use GitHub Actions). GitHub Actions currently doesn't offer arm64 hosted agents yet.Verification Process
Release Notes
Repair arm64 Linux Electron prebuilds