fix(convert/pathToUri): Improve the encoding of non-alphanumeric paths other than the file protocol #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, the test failed, |
ayame113
commented
Aug 6, 2021
test/convert.test.ts
Outdated
Comment on lines
52
to
58
| it("does not encode Windows drive specifiers", () => { | ||
| expect(Convert.pathToUri("d:\\ee\\ff.txt")).toBe("file:///d:/ee/ff.txt") | ||
| // This test only succeeds on windows. (Because of the difference in the processing method of drive characters) | ||
| // However, it is enough to test the windows drive character only on windows. | ||
| if (process.platform === "win32") { | ||
| expect(Convert.pathToUri("d:\\ee\\ff.txt")).toBe("file:///d:/ee/ff.txt") | ||
| } | ||
| }) |
There was a problem hiding this comment.
new URL("d:\\ee\\ff.txt", "file://") seems to return different results for windows and others. I changed this because I thought it would be enough if the test on the drive character was successful only on windows.
UziTech
reviewed
Aug 6, 2021
UziTech
approved these changes
Aug 6, 2021
aminya
approved these changes
Aug 6, 2021
|
🎉 This PR is included in version 1.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve ayame113/atom-ide-deno#74
There is a difference in the conversion process between
Convert.uriToPathandConvert.pathToUri.uriToPath()https://foo.bar/%40->https://foo.bar/%40https://foo.bar/%2540->https://foo.bar/%2540pathToUri()https://foo.bar/%40->https://foo.bar/%2540The decoding process of urls other than file: was changed by 6f1e149, but it seems that the encoding process was not changed.
This PR modifies the encoding process for paths other than file: .