feat: use self-contained components from atom-ide-base

atom-community · Oct 9, 2020 · 1d910f5 · 1d910f5
1 parent a175dbd
commit 1d910f5
Showing 1 changed file with 10 additions and 16 deletions.
diff --git a/lib/datatip-manager.js b/lib/datatip-manager.js
@@ -3,9 +3,6 @@
 import { CompositeDisposable, Disposable, Range, Point, TextEditor, CursorPositionChangedEventommandEvent } from "atom"
 import type { DatatipProvider, MarkdownService } from "atom-ide-base"
 import { ViewContainer } from "atom-ide-base/commons-ui/float-pane/ViewContainer"
-import { getDocumentationHtml } from "atom-ide-base/commons-ui/float-pane/HTMLView"
-import { getSnippetHtml } from "atom-ide-base/commons-ui/float-pane/SnippetView"
-
 import { ProviderRegistry } from "atom-ide-base/commons-atom/ProviderRegistry"
 
 export class DataTipManager {
@@ -365,26 +362,23 @@ export class DataTipManager {
           this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView)
         } else if (datatip.markedStrings.length > 0) {
           const grammar = editor.getGrammar().scopeName.toLowerCase()
-          const snippetHtml = await getSnippetHtml(
-            datatip.markedStrings.filter((t) => t.type === "snippet").map((t) => t.value),
-            grammar,
-            this.renderer
-          )
-          const documentationHtml = await getDocumentationHtml(
-            datatip.markedStrings.filter((t) => t.type === "markdown").map((t) => t.value),
-            grammar,
-            this.renderer
-          )
+          const snippetData = datatip.markedStrings.filter((t) => t.type === "snippet").map((t) => t.value)
+          const markdownData = datatip.markedStrings.filter((t) => t.type === "markdown").map((t) => t.value)
+
           const dataTipView = new ViewContainer({
             snippet: {
-              element: snippetHtml,
+              snippet: snippetData,
+              grammarName: grammar,
               containerClassName: "datatip-container",
               contentClassName: "datatip-snippet",
+              renderer: this.renderer
             },
-            html: {
-              element: documentationHtml,
+            markdown: {
+              markdown: markdownData,
+              grammarName: grammar,
               containerClassName: "datatip-container",
               contentClassName: "datatip-marked",
+              renderer: this.renderer
             },
           })
           this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView)