Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep levels of IDs consistent throughout #5

Closed
atn38 opened this issue Mar 30, 2022 · 0 comments
Closed

keep levels of IDs consistent throughout #5

atn38 opened this issue Mar 30, 2022 · 0 comments

Comments

@atn38
Copy link
Owner

atn38 commented Mar 30, 2022

the various functions as conceived currently take the whole JSONLD representation of EML (via emld) and convert them into tables

these tables have varying numbers of variables that can be used as ID variables and primary keys downstream

levels are
package/dataset - scope, datasetid, and revision number
entity - entity position
attribute - attribute order
attribute code - code and definition

for example, to uniquely ID a given entity, one needs the first two levels of ID variables, but to do the same for a given attribute, one needs the first three

however the way code is written now, sometimes the ID levels are obtained/generated independently within each function, which can lead to inconsistencies.

perhaps the way to solve that is to nest functions, e.g. get_dataset calls get_entities which calls get_attributes and so on

atn38 added a commit that referenced this issue Apr 7, 2022
…ssible numbers of entities as well and should keep IDs consistent. #5 #6 #3
atn38 added a commit that referenced this issue Apr 7, 2022
atn38 added a commit that referenced this issue Apr 7, 2022
…and missing codes and independent from get_attributes() #5 #6
@atn38 atn38 moved this to Todo in pkEML goal 1 Apr 7, 2022
@atn38 atn38 closed this as completed Apr 22, 2022
Repository owner moved this from Todo to Done in pkEML goal 1 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant