Unified hello handling with chat server requirements #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzovpec
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Hello. Thank you very much for your contribution. Indeed, current implementation does not correspond to the server requirements. You have shown a great ability to analyze and correspond the textual requirements to the code implementation, and that is exactly what we are looking for! Great job! I have awarded you points on Canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made two changes to the handleHello function, so that it works as specified in the lab manual, in particular it did not fulfill
PR6 and PR4.
PR6: If a user that has already logged in attempts to send a HELLO-FROM log-in request, the server must respond with a BAD-RQST-HDR message.
PR4: If a user logs in with an invalid username, the server must send a BAD-RQST-BODY message in response.
the change to meet pr6 is necessary to allow the client to retransmit HELLO-FROM and get a suitable acknowledgement if the first HELLO they received was corrupted.
VUnetid= tfr216