-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add highlights in search #167
Conversation
WalkthroughThis pull request introduces a new Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
athina/steps/search.py (1)
35-35
: Enhance the docstring with more details about the highlights structure.The docstring could be more descriptive about the expected structure and format of the highlights dictionary to help users understand how to properly use this attribute.
Consider expanding the docstring like this:
- highlights: Text snippets the LLM identifies as most relevant from each page. + highlights: Optional dictionary containing text snippets that the LLM identifies as most relevant from each page. The dictionary can contain any key-value pairs that represent highlighted content.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
athina/steps/search.py
(3 hunks)pyproject.toml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- pyproject.toml
🔇 Additional comments (2)
athina/steps/search.py (2)
51-51
: LGTM!The type hint and default value are appropriate, and the attribute follows the established pattern of optional parameters in the class.
89-92
: Consider adding validation for the highlights structure.While the integration is correct, consider adding validation for the highlights dictionary before sending it to the API to prevent potential runtime errors or invalid requests.
You might want to add basic validation like this:
"contents": { - "highlights": self.highlights, + "highlights": (self.highlights if isinstance(self.highlights, dict) else None), "summary": {"query": self.query}, },
Summary by CodeRabbit
New Features
highlights
attribute to the Search class for more dynamic API request content.Chores