Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failover docs #3

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Add failover docs #3

merged 3 commits into from
Apr 11, 2023

Conversation

banker
Copy link

@banker banker commented Apr 11, 2023

No description provided.

@banker banker mentioned this pull request Apr 11, 2023
Closed
aterleto
aterleto reviewed Apr 11, 2023
View reviewed changes
Copy link
Owner

@aterleto aterleto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some repetition so if you accept a change please confirm that the same is repeated in its repetition since I might not have flagged each twice

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/failover.md Outdated Show resolved Hide resolved
docs/failover.md Outdated Show resolved Hide resolved
banker
banker commented Apr 11, 2023
View reviewed changes
Copy link
Author

@banker banker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aterleto I think I've addressed all of your suggestions here. See my latest review comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/failover.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/failover.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/failover.md Outdated Show resolved Hide resolved
docs/failover.md Outdated Show resolved Hide resolved
Allen Terleto and others added 2 commits April 11, 2023 16:40
banker
banker commented Apr 11, 2023
View reviewed changes
Copy link
Author

@banker banker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aterleto aterleto merged commit 43a63a6 into aterleto:cross-cluster-failover Apr 11, 2023
@banker banker deleted the cross-cluster-failover-docs branch April 11, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aterleto aterleto aterleto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banker @aterleto