Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1.1.0 into main #511

Merged
merged 27 commits into from
Nov 5, 2024
Merged

Merge 1.1.0 into main #511

merged 27 commits into from
Nov 5, 2024

Conversation

atcupps
Copy link
Owner

@atcupps atcupps commented Nov 4, 2024

Update Jupiterp to v1.1.0. Changes:

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiterp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:54am

Copy link

github-actions bot commented Nov 4, 2024

Before merging this dev branch to main, ensure the following items are complete:

  • Add changes to the Changelog and to Track changes for changelog #253
  • Check accessibility tooltip text for all components
  • Test usability on both Chrome and Firefox
  • Test usability on all screen sizes, including mobile
  • Stage all associated issues to be closed when this PR merges and label them with waiting

Copy link

github-actions bot commented Nov 4, 2024

Test the core functionality of this PR by ensuring the user is able to:

  • Browse classes for all departments
  • View professor ratings on PlanetTerp from the course search
  • View class meeting locations on UMD Map from course search
  • Hover over classes on course search to see them on schedule
  • Add classes from any department to schedule
  • Remove courses from their schedule via course search
  • Remove courses from their schedule via schedule UI
  • Click on any course in schedule UI to view more information
  • View course on Testudo from course information panel
  • Remove course information panel from schedule UI
  • Toggle dark mode, and have dark mode preference save
  • Add several overlapping courses without any being hidden
  • Close the page and return to see the same courses saved
  • Add and switch between multiple schedules
  • Leave the page and return with all their saved schedules still there

@atcupps atcupps added this to the 3: v1.1.0 milestone Nov 4, 2024
@atcupps atcupps added C - site Component: `site` A - architecture Area: Overall architecture or design A - ui/ux Area: UI/UX design A - site backend Area: Site backend, server, data loading, etc. A - schedule Area: Schedule building system labels Nov 4, 2024
@atcupps atcupps linked an issue Nov 4, 2024 that may be closed by this pull request
@atcupps atcupps marked this pull request as ready for review November 4, 2024 21:13
@atcupps atcupps requested a review from alanliu2009 November 4, 2024 21:13
Copy link
Collaborator

@alanliu2009 alanliu2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user doesn't name their original schedule, clicking the 'plus' icon creates a new schedule called "Copy of My Schedule", but it isn't a copy. Maybe change this to be called "New Schedule" on addition, and "New New Schedule" if "New Schedule" is taken?

@atcupps
Copy link
Owner Author

atcupps commented Nov 5, 2024

@alanliu2009 try now

Copy link
Collaborator

@alanliu2009 alanliu2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atcupps atcupps merged commit e901463 into main Nov 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A - architecture Area: Overall architecture or design A - schedule Area: Schedule building system A - site backend Area: Site backend, server, data loading, etc. A - ui/ux Area: UI/UX design C - site Component: `site`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable adding multiple schedules
3 participants