Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schedule scaling reactivity #315

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix schedule scaling reactivity #315

merged 2 commits into from
May 24, 2024

Conversation

atcupps
Copy link
Owner

@atcupps atcupps commented May 23, 2024

Resolves #302 and Resolves #230

@alanliu2009 check that the lines in the background match correctly with flipping screen on mobile or resizing window on desktop.

@atcupps atcupps added C - site Component: `site` A - ui/ux Area: UI/UX design labels May 23, 2024
@atcupps atcupps added this to the 1: URGENT Fix ASAP milestone May 23, 2024
@atcupps atcupps requested a review from alanliu2009 May 23, 2024 02:39
@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiterp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:02am

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited by atcupps
Loading

🚨 Hi @atcupps, are you sure you want to merge directly into the main branch and not a development branch? Please check the box to confirm:

  • I, @atcupps, confirm that main is the intended target branch of this pull request.

alanliu2009
alanliu2009 requested changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@alanliu2009 alanliu2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the window is shifted from a large window to a small window, the "Class Added" banner shows up consistently.

@atcupps
Copy link
Owner Author

atcupps commented May 24, 2024

@alanliu2009 this should be fixed

@atcupps atcupps requested a review from alanliu2009 May 24, 2024 01:01
@alanliu2009 alanliu2009 merged commit 5d69452 into main May 24, 2024
6 checks passed
@alanliu2009 alanliu2009 deleted the fixlines branch May 24, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanliu2009 alanliu2009 alanliu2009 approved these changes

Assignees
No one assigned
Labels
A - ui/ux Area: UI/UX design C - site Component: `site`
Projects
None yet
Milestone
1: URGENT Fix ASAP
2 participants
@atcupps @alanliu2009