Add tests using testdata input files #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add collection of testdata files
- `input`
- `encoded-all`
- `encoded-mixed`
- `invalid-all`
- `invalid-mixed`
- `output`
- `embedded`
- `standalone`
- add "exported" tests which focus strictly on exported functionality
of the `internal/safelinks` package
- add minor dependency on the `google/go-cmp` package for some tests
- add brief README for testdata content to explain purpose,
importantance of preserving the exact formatting (mostly specific
EOL) within the input and output testdata files
Add new testdata URLs with a url parameter
Help ensure that recent changes to require known safelinks "base"
domain to be present in Safe Links URLs continutes to function
as intended.
Previously, these input URLs would have been incorrectly flagged
as Safe Links URLs and "decoded" into the value of the `url`
query parameter.
refs GH-251
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
input-encoded-all-encoded-mixed-invalid-all-invalid-mixedoutputembeddedstandaloneinternal/safelinkspackagegoogle/go-cmppackage for some testsAdd new testdata URLs with a url parameter
Help ensure that recent changes to require known safelinks "base" domain to be present in Safe Links URLs continutes to function as intended.
Previously, these input URLs would have been incorrectly flagged as Safe Links URLs and "decoded" into the value of the
urlquery parameter.References