Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor support for decoding text streams #210

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Refactor support for decoding text streams #210

merged 1 commit into from
Mar 11, 2024

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Mar 11, 2024

  • Refactor core of pollInputSource to processInput func
  • Refactor core loop out of GetURLPatternsUsingIndex into separate getURLIndexEndPosition func

refs GH-185

@atc0005
Refactor support for decoding text streams
0b8ac0a 
- Refactor core of `pollInputSource` to `processInput` func
- Refactor core loop out of `GetURLPatternsUsingIndex` into
  separate `getURLIndexEndPosition` func

refs GH-185
@atc0005 atc0005 added this to the Next Dev Release milestone Mar 11, 2024
@atc0005 atc0005 self-assigned this Mar 11, 2024
@atc0005 atc0005 merged commit 685907f into development Mar 11, 2024
29 checks passed
@atc0005 atc0005 deleted the i185-refactor-support-for-decoding-text-streams branch March 11, 2024 11:24
atc0005 added a commit that referenced this pull request Mar 28, 2024
@atc0005
Fix GetURLPatternsUsingIndex URL end pos matching
a9bbbea 
Previous refactoring for 0b8ac0a
incorrectly passed the same slice into the helper function that
it needed to initially calculate on its own.

However, since GetURLPatternsUsingIndex was not called by
the `dsl` tool it was unaffected by this issue.

refs GH-210
refs GH-185
@atc0005 atc0005 mentioned this pull request Mar 28, 2024
Merged
atc0005 added a commit that referenced this pull request Apr 9, 2024
@atc0005
Fix GetURLPatternsUsingIndex URL end pos matching
a40455f 
Previous refactoring for 0b8ac0a
incorrectly passed the same slice into the helper function that
it needed to initially calculate on its own.

However, since GetURLPatternsUsingIndex was not called by
the `dsl` tool it was unaffected by this issue.

refs GH-210
refs GH-185
@atc0005 atc0005 mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
refactor
Projects
None yet
Milestone
v0.4.0-alpha.4
Development

Successfully merging this pull request may close these issues.
1 participant
@atc0005