Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abandoned orijtech/httperroryzer linter #1849

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ Unless indicated otherwise, the following linting tools are included in the
| [`deadcode`](https://pkg.go.dev/golang.org/x/tools/cmd/deadcode) | `v0.29.0` |
| [`pelletier/go-toml`](https://github.com/pelletier/go-toml) | `v2.2.3` |

Forks:

| Linter | Version |
| -------------------------------------------------------------------- | ------------------------------------------ |
| [`orijtech/httperroryzer`](https://github.com/atc0005/httperroryzer) | `9f94717820d4a5075117680de2ca07875d32c9f1` |

## Build tools included

The following build tools are included in all `*-build*` images *except* for
Expand Down Expand Up @@ -426,7 +420,6 @@ each release of this project.
- [govulncheck](https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck)
- [deadcode](https://pkg.go.dev/golang.org/x/tools/cmd/deadcode)
- Additional
- [orijtech/httperroryzer](https://github.com/orijtech/httperroryzer)
- [pelletier/go-toml](https://github.com/pelletier/go-toml)
- Build Tools
- [tc-hib/go-winres](https://github.com/tc-hib/go-winres)
Expand Down
21 changes: 0 additions & 21 deletions oldstable/combined/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,9 @@ ENV GOLANGCI_LINT_VERSION="v1.63.4"
ENV STATICCHECK_VERSION="v0.5.1"
ENV DEADCODE_VERSION="v0.29.0"
ENV GOVULNCHECK_VERSION="v1.1.4"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
ENV TOMLL_VERSION="v2.2.3"
ENV GOTESTDOX_VERSION="v0.2.2"

# These commits/versions are provided by temporary forks of the upstream
# projects. The plan is to switch back to current upstream vesions once
# the required dependencies are updated for those upstream projects.
ENV HTTPERRORYZER_VERSION="9f94717820d4a5075117680de2ca07875d32c9f1"

RUN echo "Installing staticcheck@${STATICCHECK_VERSION}" \
&& go install honnef.co/go/tools/cmd/staticcheck@${STATICCHECK_VERSION} \
&& staticcheck --version
Expand All @@ -48,14 +42,6 @@ RUN echo "Installing gotestdox@${GOTESTDOX_VERSION}" \
&& go install github.com/bitfield/gotestdox/cmd/gotestdox@${GOTESTDOX_VERSION} \
&& go version -m $(which gotestdox)

RUN echo "Installing httperroryzer from temporary fork" \
&& git clone https://github.com/atc0005/httperroryzer \
&& cd httperroryzer \
&& git checkout ${HTTPERRORYZER_VERSION} \
&& go install ./cmd/httperroryzer \
&& go version -m $(which httperroryzer) \
&& cd ..

# RUN echo "Installing golangci-lint from dev feat/go1.20 branch" \
# && git clone https://github.com/atc0005/golangci-lint \
# && cd golangci-lint \
Expand Down Expand Up @@ -94,12 +80,6 @@ ENV DEADCODE_VERSION="v0.29.0"
ENV GOVULNCHECK_VERSION="v1.1.4"
ENV TOMLL_VERSION="v2.2.3"
ENV GOTESTDOX_VERSION="v0.2.2"

# These commits/versions are provided by temporary forks of the upstream
# projects. The plan is to switch back to current upstream vesions once
# the required dependencies are updated for those upstream projects.
ENV HTTPERRORYZER_VERSION="9f94717820d4a5075117680de2ca07875d32c9f1"

ENV APT_BSDMAINUTILS_VERSION="12.1.8"
ENV APT_TREE_VERSION="2.1.0-1"
ENV APT_FILE_VERSION="1:5.44-3"
Expand All @@ -117,7 +97,6 @@ COPY --from=builder /go/bin/golangci-lint /usr/bin/golangci-lint
COPY --from=builder /go/bin/govulncheck /usr/bin/govulncheck
COPY --from=builder /go/bin/deadcode /usr/bin/deadcode
COPY --from=builder /go/bin/gotestdox /usr/bin/gotestdox
COPY --from=builder /go/bin/httperroryzer /usr/bin/httperroryzer
COPY --from=builder /go/bin/tomll /usr/bin/tomll

# Copy over linting config files to root of container image to serve as a
Expand Down
22 changes: 0 additions & 22 deletions stable/combined/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,9 @@ ENV GOLANGCI_LINT_VERSION="v1.63.4"
ENV STATICCHECK_VERSION="v0.5.1"
ENV DEADCODE_VERSION="v0.29.0"
ENV GOVULNCHECK_VERSION="v1.1.4"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
ENV TOMLL_VERSION="v2.2.3"
ENV GOTESTDOX_VERSION="v0.2.2"

# These commits/versions are provided by temporary forks of the upstream
# projects. The plan is to switch back to current upstream vesions once
# the required dependencies are updated for those upstream projects.
ENV HTTPERRORYZER_VERSION="9f94717820d4a5075117680de2ca07875d32c9f1"

RUN echo "Installing staticcheck@${STATICCHECK_VERSION}" \
&& go install honnef.co/go/tools/cmd/staticcheck@${STATICCHECK_VERSION} \
&& staticcheck --version
Expand All @@ -59,14 +53,6 @@ RUN echo "Installing gotestdox@${GOTESTDOX_VERSION}" \
&& go install github.com/bitfield/gotestdox/cmd/gotestdox@${GOTESTDOX_VERSION} \
&& go version -m $(which gotestdox)

RUN echo "Installing httperroryzer from temporary fork" \
&& git clone https://github.com/atc0005/httperroryzer \
&& cd httperroryzer \
&& git checkout ${HTTPERRORYZER_VERSION} \
&& go install ./cmd/httperroryzer \
&& go version -m $(which httperroryzer) \
&& cd ..

# RUN echo "Installing golangci-lint from dev feat/go1.20 branch" \
# && git clone https://github.com/atc0005/golangci-lint \
# && cd golangci-lint \
Expand Down Expand Up @@ -112,15 +98,8 @@ ENV STATICCHECK_VERSION="v0.5.1"

ENV DEADCODE_VERSION="v0.29.0"
ENV GOVULNCHECK_VERSION="v1.1.4"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
ENV TOMLL_VERSION="v2.2.3"
ENV GOTESTDOX_VERSION="v0.2.2"

# These commits/versions are provided by temporary forks of the upstream
# projects. The plan is to switch back to current upstream vesions once
# the required dependencies are updated for those upstream projects.
ENV HTTPERRORYZER_VERSION="9f94717820d4a5075117680de2ca07875d32c9f1"

ENV APT_BSDMAINUTILS_VERSION="12.1.8"
ENV APT_TREE_VERSION="2.1.0-1"
ENV APT_FILE_VERSION="1:5.44-3"
Expand All @@ -138,7 +117,6 @@ COPY --from=builder /go/bin/golangci-lint /usr/bin/golangci-lint
COPY --from=builder /go/bin/govulncheck /usr/bin/govulncheck
COPY --from=builder /go/bin/deadcode /usr/bin/deadcode
COPY --from=builder /go/bin/gotestdox /usr/bin/gotestdox
COPY --from=builder /go/bin/httperroryzer /usr/bin/httperroryzer
COPY --from=builder /go/bin/tomll /usr/bin/tomll

# Copy over linting config files to root of container image to serve as a
Expand Down
3 changes: 0 additions & 3 deletions tools/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ require (
// golangci-lint - intended as a primary linter
github.com/golangci/golangci-lint v1.63.4

// httperroryzer - provided as an optional linter
github.com/orijtech/httperroryzer v0.0.1

// tomll - provided as an optional linter
github.com/pelletier/go-toml/v2 v2.2.3

Expand Down
2 changes: 0 additions & 2 deletions tools/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ github.com/nfnt/resize v0.0.0-20180221191011-83c6a9932646 h1:zYyBkD/k9seD2A7fsi6
github.com/nfnt/resize v0.0.0-20180221191011-83c6a9932646/go.mod h1:jpp1/29i3P1S/RLdc7JQKbRpFeM1dOBd8T9ki5s+AY8=
github.com/onsi/gomega v1.34.1 h1:EUMJIKUjM8sKjYbtxQI9A4z2o+rruxnzNvpknOXie6k=
github.com/onsi/gomega v1.34.1/go.mod h1:kU1QgUvBDLXBJq618Xvm2LUX6rSAfRaFRTcdOeDLwwY=
github.com/orijtech/httperroryzer v0.0.1 h1:85v2h0lGsa4X1DvOpuMmR+mimG7bGYYRbOWTmE/YOi4=
github.com/orijtech/httperroryzer v0.0.1/go.mod h1:j1TGk7yN1XWUoNrjJTs8V+FNmonAdmfjJJvbt2fOTxs=
github.com/pelletier/go-toml/v2 v2.2.3 h1:YmeHyLY8mFWbdkNWwpr+qIL2bEqT0o95WSdkNHvL12M=
github.com/pelletier/go-toml/v2 v2.2.3/go.mod h1:MfCQTFTvCcUyyvvwm1+G6H/jORL20Xlb6rzQu9GuUkc=
github.com/pjbgf/sha1cd v0.3.0 h1:4D5XXmUUBUl/xQ6IjCkEAbqXskkq/4O7LmGn0AqMDs4=
Expand Down
1 change: 0 additions & 1 deletion tools/tools.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
_ "github.com/choffmeister/git-describe-semver"
_ "github.com/golangci/golangci-lint/pkg/config"
_ "github.com/goreleaser/nfpm/v2"
_ "github.com/orijtech/httperroryzer"
_ "github.com/pelletier/go-toml/v2"
_ "github.com/tc-hib/go-winres"
_ "golang.org/x/tools/cmd/deadcode"
Expand Down
21 changes: 0 additions & 21 deletions unstable/combined/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,9 @@ ENV STATICCHECK_VERSION="v0.5.1"

ENV DEADCODE_VERSION="v0.29.0"
ENV GOVULNCHECK_VERSION="v1.1.4"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
ENV TOMLL_VERSION="v2.2.3"
ENV GOTESTDOX_VERSION="v0.2.2"

# These commits/versions are provided by temporary forks of the upstream
# projects. The plan is to switch back to current upstream vesions once
# the required dependencies are updated for those upstream projects.
ENV HTTPERRORYZER_VERSION="9f94717820d4a5075117680de2ca07875d32c9f1"

RUN echo "Installing staticcheck@${STATICCHECK_VERSION}" \
&& go install honnef.co/go/tools/cmd/staticcheck@${STATICCHECK_VERSION} \
&& staticcheck --version
Expand All @@ -59,13 +53,6 @@ RUN echo "Installing gotestdox@${GOTESTDOX_VERSION}" \
&& go install github.com/bitfield/gotestdox/cmd/gotestdox@${GOTESTDOX_VERSION} \
&& go version -m $(which gotestdox)

RUN echo "Installing httperroryzer from temporary fork" \
&& git clone https://github.com/atc0005/httperroryzer \
&& cd httperroryzer \
&& git checkout ${HTTPERRORYZER_VERSION} \
&& go install ./cmd/httperroryzer \
&& cd ..

# RUN echo "Installing golangci-lint from dev feat/go1.23 branch" \
# && git clone https://github.com/atc0005/golangci-lint \
# && cd golangci-lint \
Expand Down Expand Up @@ -112,15 +99,8 @@ ENV STATICCHECK_VERSION="v0.5.1"

ENV DEADCODE_VERSION="v0.29.0"
ENV GOVULNCHECK_VERSION="v1.1.4"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
ENV TOMLL_VERSION="v2.2.3"
ENV GOTESTDOX_VERSION="v0.2.2"

# These commits/versions are provided by temporary forks of the upstream
# projects. The plan is to switch back to current upstream vesions once
# the required dependencies are updated for those upstream projects.
ENV HTTPERRORYZER_VERSION="9f94717820d4a5075117680de2ca07875d32c9f1"

ENV APT_BSDMAINUTILS_VERSION="12.1.8"
ENV APT_TREE_VERSION="2.1.0-1"
ENV APT_FILE_VERSION="1:5.44-3"
Expand All @@ -138,7 +118,6 @@ COPY --from=builder /go/bin/golangci-lint /usr/bin/golangci-lint
COPY --from=builder /go/bin/govulncheck /usr/bin/govulncheck
COPY --from=builder /go/bin/deadcode /usr/bin/deadcode
COPY --from=builder /go/bin/gotestdox /usr/bin/gotestdox
COPY --from=builder /go/bin/httperroryzer /usr/bin/httperroryzer
COPY --from=builder /go/bin/tomll /usr/bin/tomll

# Copy over linting config files to root of container image to serve as a
Expand Down
Loading