Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property $ref is not allowed warning for all $ref usage in parameter objects #527

Closed
trudeaua-vividream-software opened this issue Dec 12, 2022 · 3 comments
Labels
bug Something isn't working stale

Comments

@trudeaua-vividream-software
Copy link

trudeaua-vividream-software commented Dec 12, 2022

Describe the bug

I'm not sure whether this is the right place for this issue, or if the spec-json-schemas repo is, but I'm not totally sure that the other repo is relevant, so figured posting here was a safe bet to start. If you guys could point me in the right direction, I'd be happy to take this issue to whatever other relevant repo it should land at 👍

When making YAML AsyncAPI documents in AsyncAPI Studio's web app, $ref field usage in a parameter object (within the parameters parent object) triggers the warning "Property $ref is not allowed".

I only saw this happening for $ref usage in the context described above - other usages of $ref don't seem to spawn warnings.

How to Reproduce

  • In a private/incognito tab (or any browser environment where AsyncAPI Studio's web app won't have any existing local data), open https://studio.asyncapi.com/
  • Observe the warning occurs in the contexts described above

Relevant Screenshot:

image

Expected behavior

$ref field usage in a parameter object (within the parameters parent object) does not cause a warning in AsyncAPI Studio.

@trudeaua-vividream-software trudeaua-vividream-software added the bug Something isn't working label Dec 12, 2022
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@trudeaua-vividream-software trudeaua-vividream-software changed the title Property $ref is not allowed warning for all $ref usage in parameters Property $ref is not allowed warning for all $ref usage in parameter objects Dec 12, 2022
@magicmatatjahu
Copy link
Member

@trudeaua-vividream-software Hi! Thanks for the issue! We also found that bug and we created ticket in appropriate repository - asyncapi/spec-json-schemas#296 I will leave open that issue and I will close when we will fix that in json-schema.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Apr 13, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2023
KhudaDad414 pushed a commit to KhudaDad414/studio that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants