Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README with new logo banner #732

Merged
merged 2 commits into from
Mar 14, 2022
Merged

docs: update README with new logo banner #732

merged 2 commits into from
Mar 14, 2022

Conversation

pk-218
Copy link
Contributor

@pk-218 pk-218 commented Mar 13, 2022 •
edited by derberg
Loading

title: "✏️ Logo update"

Related issue(s):
fixes #729

Changes made:

  • Make sure you are using Markdown syntax only
  • Be sure to remove the old logo as well as the old title of the repo as this image will replace both elements

Deleted old logo and added new logo banner in ./assets/logo.png

Updated README [![AsyncAPI Logo](./assets/logo.png)](https://www.asyncapi.com)

  • If there is any description text below the repo title, let's make it left-aligned if it isn't already, so as to match the left-alignment of the content in the new banner image

Sponsor logos were present instead of any description text, hence did not change the alignment

github-actions[bot]
github-actions bot reviewed Mar 13, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@pk-218 pk-218 mentioned this pull request Mar 13, 2022
Closed
@pk-218 pk-218 changed the title Docs: Update README with new logo banner docs: Update README with new logo banner Mar 13, 2022
@pk-218 pk-218 changed the title docs: Update README with new logo banner docs: update README with new logo banner Mar 13, 2022
fmvilas
fmvilas approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mcturco
mcturco approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@mcturco mcturco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @pk-218!! 🚢

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member

derberg commented Mar 14, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit f353b1c into asyncapi:master Mar 14, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@fmvilas fmvilas fmvilas approved these changes

@mcturco mcturco mcturco approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README with new logo banner
5 participants
@pk-218 @derberg @asyncapi-bot @fmvilas @mcturco