Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add v3.0.0 schemas #180

Closed
wants to merge 7 commits into from

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Mar 14, 2022

Description
This PR adds the new schemas for v3.0.0 so we can start applying changes.

This PR also merges the changes from Master that have happened since the branch was created.

fixes #175

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

Should this live on it's own branch instead of next-major 🤔

@magicmatatjahu
Copy link
Member

@jonaslagoni I guess next-major refers to the next (major) version of AsyncAPI, right? If yes, then it's ok.

@jonaslagoni
Copy link
Member Author

I will re-target this for next-spec-major once created, as that is where it will live until 3.0 is released.

@KhudaDad414
Copy link
Member

@jonaslagoni I have been thinking about moving bindings schemas here and saw that this branch can be a good place to add them if we want to have bindings schemas for 3.0.0 of course. Are there any plans on merging this so I can open a PR for bindings?

@jonaslagoni
Copy link
Member Author

@jonaslagoni I have been thinking about moving bindings schemas here and saw that this branch can be a good place to add them if we want to have bindings schemas for 3.0.0 of course. Are there any plans on merging this so I can open a PR for bindings?

Yep!

I will create the corresponding branches and changes Monday next week so we can start moving this along 🙂

@jonaslagoni jonaslagoni changed the title feat: add v3.0.0 schemas chore: add v3.0.0 schemas Apr 13, 2022
@asyncapi-bot asyncapi-bot deleted the branch asyncapi:master May 16, 2022 16:55
@jonaslagoni
Copy link
Member Author

Damn, when targeted branches are removed, remaining PRs are closed as well with no way to retarget them...

@derberg
Copy link
Member

derberg commented May 16, 2022

why would you remove next-major ?

@jonaslagoni
Copy link
Member Author

@derberg bot did when I used /rtm

@jonaslagoni
Copy link
Member Author

I cannot re-open my own PRs 🤨 Can you @derberg?

@derberg derberg reopened this May 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni changed the base branch from next-major to master May 17, 2022 09:04
@jonaslagoni
Copy link
Member Author

Thats a lot of conflicts for something so easy as running a single command... Gonna remake it.

@jonaslagoni jonaslagoni deleted the new_spec_version branch May 17, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare new 3.0 spec JSON Schema files
5 participants