Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: assign optional/non required arguments in the constructor if pr… #586

Merged
merged 4 commits into from
Jan 15, 2022
Merged

feat: assign optional/non required arguments in the constructor if pr… #586

merged 4 commits into from
Jan 15, 2022

Conversation

mahakporwal02
Copy link
Contributor

Enhancement to javascript generator to assign optional/non required arguments in the constructor during object formation.

Related issue(s)
#581

@coveralls
Copy link

coveralls commented Jan 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1699541673

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 93.584%
Totals Coverage Status
Change from base Build 1699198161: 0.008%
Covered Lines: 2371
Relevant Lines: 2417
💛 - Coveralls

@mahakporwal02 mahakporwal02 changed the title feat: Assign optional/non required arguments in the constructor if pr… feat: assign optional/non required arguments in the constructor if pr… Jan 14, 2022
@mahakporwal02
Copy link
Contributor Author

@jonaslagoni Kindly review the PR.

jonaslagoni
jonaslagoni approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@jonaslagoni
Copy link
Member

/rtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni merged commit 5622923 into asyncapi:master Jan 15, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahakporwal02 @coveralls @jonaslagoni @asyncapi-bot