chore: added nvmrc

[ritik307]

Description

• Added command to implement and install .nvmrc.
• Updated docs/development.md with the commands to setup .nvmrc

Related issue(s)
Resolves #575

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[ritik307]

@fmvilas @derberg @ron-debajyoti kindly review the PR

[ron-debajyoti]

@fmvilas @derberg @ron-debajyoti kindly review the PR

I'm not a maintainer tbh, just another fellow contributor 😄 @jonaslagoni

[jonaslagoni]

@ritik307 Thanks for taking the time to do this 👍

One question, is there any reason you see us needing the script nvmrc rather than just committing that file? That way the steps others need to do it only nvm use 🤔

[ritik307]

@ritik307 Thanks for taking the time to do this +1

One question, is there any reason you see us needing the script nvmrc rather than just committing that file? That way the steps others need to do it only nvm use thinking

I think the implemented approach is better bcz there won't be a need for a dev to have nvm already installed in their machine and also if a dev doesn't require nvmrc file they still have to keep it in the root folder regardless. I don't have any problem switching to the way you are thinking to implement this I will update the PR accordingly.

[jonaslagoni]

I think the implemented approach is better bcz there won't be a need for a dev to have nvm already installed in their machine and also if a dev doesn't require nvmrc file they still have to keep it in the root folder regardless

Regardless of this approach or the other, would they not need nvm installed anyway?

The only difference I see is that, with your script, we can "dynamically` create the appropriate nvmrc file. However, as the node requirement wont really change, having it hardcoded might be a better fit 🙂

[ritik307]

I think the implemented approach is better bcz there won't be a need for a dev to have nvm already installed in their machine and also if a dev doesn't require nvmrc file they still have to keep it in the root folder regardless

Regardless of this approach or the other, would they not need nvm installed anyway?

The only difference I see is that, with your script, we can "dynamically` create the appropriate nvmrc file. However, as the node requirement wont really change, having it hardcoded might be a better fit slightly_smiling_face

Done! kindly review

[jonaslagoni]

Got a few follow up questions 🙂

Also for the title of the PR, please use chore: as this is not a feature for the library, but a feature for the development setup 🙂

[jonaslagoni]

LGTM! 🎉

[jonaslagoni]

/rtm

[coveralls]

Pull Request Test Coverage Report for Build 1698990891

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.575%

---

Totals
Change from base Build 1697691553:	0.0%
Covered Lines:	2368
Relevant Lines:	2414

---

💛 - Coveralls

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[jonaslagoni]

@all-contributors please add @ritik307 for doc

[allcontributors]

@jonaslagoni

I've put up a pull request to add @ritik307! 🎉

[asyncapi-bot]

🎉 This PR is included in version 0.44.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[asyncapi-bot]

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀