fix: removing TypeScript exported base model #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1654555782
💛 - Coveralls |
magicmatatjahu
previously approved these changes
Jan 4, 2022
|
/rtm |
|
Kudos, SonarCloud Quality Gate passed!
|
magicmatatjahu
approved these changes
Jan 4, 2022
|
Hmm, funny... So for the BlackBox tests when we render the type as: interface Response {}
For now, I am gonna disable the tests, and re-enable them in #536 |
|
/rtm |
|
🎉 This PR is included in version 0.40.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-next.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TypeScript renderers do more than provide the base data model, it also exports them and targets ESM module systems. This is a problem because the assumption is that the render renders a base data model that can be built upon after the rendering.
This PR removes that export functionality.
Related issue(s)
Related to #536