Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to change the size of the split panes in the Playground #270

Merged
merged 4 commits into from
Mar 23, 2021
Merged

feat: ability to change the size of the split panes in the Playground #270

merged 4 commits into from
Mar 23, 2021

Conversation

aayushmau5
Copy link
Member

Description

Changes proposed in this pull request:

  • Added the ability to change the size of split panes
  • Used a library called react-split

Related issue(s)

Fixes #268

github-actions[bot]
github-actions bot reviewed Mar 22, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@aayushmau5 aayushmau5 changed the title feat:ability to change the size of the split panes feat: ability to change the size of the split panes Mar 22, 2021
@magicmatatjahu magicmatatjahu added area/playground Related to all activities around Playground app enhancement New feature or request labels Mar 23, 2021
magicmatatjahu
magicmatatjahu reviewed Mar 23, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Please refer to my one suggestion :)

@aayushmau5
Copy link
Member Author

@magicmatatjahu Done :D

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu
Copy link
Member

@aayushmau5 Thanks for contribution!

@magicmatatjahu magicmatatjahu merged commit 35116f9 into asyncapi:master Mar 23, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg derberg changed the title feat: ability to change the size of the split panes feat: ability to change the size of the split panes in the Playground Mar 23, 2021
@derberg
Copy link
Member

derberg commented Mar 23, 2021

@magicmatatjahu I think we need to consider using scopes in future commit messages to indicate that change is for example only for the Playground, or only for web component. Although we still need it in commit text so it is clear in the release notes

@derberg
Copy link
Member

derberg commented Mar 24, 2021

@all-contributors please add @aayushmau5 for code

@allcontributors allcontributors bot mentioned this pull request Mar 24, 2021
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @aayushmau5! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

Assignees
No one assigned
Labels
area/playground Related to all activities around Playground app enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to change the size of the split panes
4 participants
@aayushmau5 @magicmatatjahu @asyncapi-bot @derberg