Skip to content

Commit

Permalink
fix(toggle): hide on/off test for screen readers
Browse files Browse the repository at this point in the history
  • Loading branch information
asudoh committed Feb 13, 2019
1 parent 84a6c82 commit cfd75ca
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions src/components/toggle/toggle--small.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,30 @@
<div class="{{@root.prefix}}--form-item">
<input class="{{@root.prefix}}--toggle {{@root.prefix}}--toggle--small" id="toggle4" type="checkbox" aria-label="Label Name">
<label class="{{@root.prefix}}--toggle__label" for="toggle4">
<span class="{{@root.prefix}}--toggle__text--left">Off</span>
<span class="{{@root.prefix}}--toggle__text--left" aria-hidden="true">Off</span>
<span class="{{@root.prefix}}--toggle__appearance">
{{#unless componentsX}}
<svg class="{{@root.prefix}}--toggle__check" width="6px" height="5px" viewBox="0 0 6 5">
<path d="M2.2 2.7L5 0 6 1 2.2 5 0 2.7 1 1.5z" />
</svg>
{{/unless}}
</span>
<span class="{{@root.prefix}}--toggle__text--right">On</span>
<span class="{{@root.prefix}}--toggle__text--right" aria-hidden="true">On</span>
</label>
</div>

<div class="{{@root.prefix}}--form-item">
<input class="{{@root.prefix}}--toggle {{@root.prefix}}--toggle--small" id="toggle5" type="checkbox" aria-label="Label Name"
disabled>
<label class="{{@root.prefix}}--toggle__label" for="toggle5">
<span class="{{@root.prefix}}--toggle__text--left">Off</span>
<span class="{{@root.prefix}}--toggle__text--left" aria-hidden="true">Off</span>
<span class="{{@root.prefix}}--toggle__appearance">
{{#unless componentsX}}
<svg class="{{@root.prefix}}--toggle__check" width="6px" height="5px" viewBox="0 0 6 5">
<path d="M2.2 2.7L5 0 6 1 2.2 5 0 2.7 1 1.5z" />
</svg>
{{/unless}}
</span>
<span class="{{@root.prefix}}--toggle__text--right">On</span>
<span class="{{@root.prefix}}--toggle__text--right" aria-hidden="true">On</span>
</label>
</div>
12 changes: 6 additions & 6 deletions src/components/toggle/toggle.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
<div class="{{@root.prefix}}--form-item">
<input class="{{@root.prefix}}--toggle" id="toggle1" type="checkbox">
<label class="{{@root.prefix}}--toggle__label" for="toggle1">
<span class="{{@root.prefix}}--toggle__text--left">Off</span>
<span class="{{@root.prefix}}--toggle__text--left" aria-hidden="true">Off</span>
<span class="{{@root.prefix}}--toggle__appearance"></span>
<span class="{{@root.prefix}}--toggle__text--right">On</span>
<span class="{{@root.prefix}}--toggle__text--right" aria-hidden="true">On</span>
</label>
</div>

Expand All @@ -19,18 +19,18 @@
<div class="{{@root.prefix}}--form-item">
<input class="{{@root.prefix}}--toggle" id="toggle2" type="checkbox">
<label class="{{@root.prefix}}--toggle__label" for="toggle2">
<span class="{{@root.prefix}}--toggle__text--left">Off</span>
<span class="{{@root.prefix}}--toggle__text--left" aria-hidden="true">Off</span>
<span class="{{@root.prefix}}--toggle__appearance"></span>
<span class="{{@root.prefix}}--toggle__text--right">On</span>
<span class="{{@root.prefix}}--toggle__text--right" aria-hidden="true">On</span>
</label>
</div>
</fieldset>

<div class="{{@root.prefix}}--form-item">
<input class="{{@root.prefix}}--toggle" id="toggle3" type="checkbox" disabled>
<label class="{{@root.prefix}}--toggle__label" for="toggle3">
<span class="{{@root.prefix}}--toggle__text--left">Off</span>
<span class="{{@root.prefix}}--toggle__text--left" aria-hidden="true">Off</span>
<span class="{{@root.prefix}}--toggle__appearance"></span>
<span class="{{@root.prefix}}--toggle__text--right">On</span>
<span class="{{@root.prefix}}--toggle__text--right" aria-hidden="true">On</span>
</label>
</div>

0 comments on commit cfd75ca

Please sign in to comment.