Fix a bug that caused big-endian dask arrays to not be reprojected correctly #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
commented
Feb 1, 2025
| @@ -53,7 +53,7 @@ def _dask_to_numpy_memmap(dask_array, tmp_dir): | |||
|
|
|||
| memmapped_array = np.memmap( | |||
| memmap_path, | |||
| dtype=zarr_array.dtype, | |||
| dtype=float, | |||
There was a problem hiding this comment.
The memmap was read later on assuming it was native float.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
+ Coverage 90.90% 91.00% +0.10%
==========================================
Files 25 25
Lines 1077 1078 +1
==========================================
+ Hits 979 981 +2
+ Misses 98 97 -1 ☔ View full report in Codecov by Sentry. |
|
I think I need to check the case where |
|
But for now I think it should work @keflavich |
|
Yes, this solves the problem; I didn't realize there was a dask reader/converter built in to reproject. I'll rebase #474 against this and remove the hack I implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm surprised I didn't run into this sooner, but this should fix the endianness issue @keflavich - can you confirm?