Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: IRSA: adding servicetype to list_collections #3200

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Feb 3, 2025

We have cached two collection listing queries to help separating out image vs spectral services. This doesn't have to wait until all the issues are sorted upstream for the SSA PR.

closes #3077

@bsipocz bsipocz added this to the v0.4.10 milestone Feb 3, 2025
@bsipocz bsipocz requested a review from keflavich February 3, 2025 22:31
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.32%. Comparing base (0fb73cd) to head (90a44d5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/ipac/irsa/core.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   68.34%   68.32%   -0.03%     
==========================================
  Files         231      231              
  Lines       19190    19197       +7     
==========================================
  Hits        13116    13116              
- Misses       6074     6081       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz force-pushed the ENH_irsa_collection_kwarg branch from a2e9b04 to 90a44d5 Compare February 12, 2025 05:14
@bsipocz bsipocz merged commit e58ae49 into astropy:main Feb 12, 2025
10 of 12 checks passed
@bsipocz bsipocz deleted the ENH_irsa_collection_kwarg branch February 12, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API discussion for list_collections
1 participant