Fix issue 2889: NIST wl keyword #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
=======================================
Coverage 67.30% 67.30%
=======================================
Files 235 235
Lines 18135 18135
=======================================
Hits 12206 12206
Misses 5929 5929 ☔ View full report in Codecov by Sentry. |
Closed
bsipocz
reviewed
Jan 8, 2024
Comment on lines
+49
to
+52
| # check that non-supported units default to angstroms | ||
| result = nist.core.Nist.query(4101 * 1e-10 * u.m, 4103 * 1e-10 * u.m) | ||
| assert result['Ritz'].min() >= 4101 | ||
| assert result['Ritz'].max() <= 4103 |
There was a problem hiding this comment.
Wow, this is totally unexpected. Would you mention it in the narrative docs?
Or, alternative we should instead return a QTable with units properly set on the column.
There was a problem hiding this comment.
QTable seems the better solution; I think we should punt to the next PR though.
bsipocz
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIST changed the keyword specification for wavelengths at some point in the last 11 years. This fixes the keywords that no longer seem to be supported.