-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to access a vizier catalog's metadata information #2878
Conversation
Thank you for the update ! I propose minor changes in sematic (to be more close from VizieR) : description -> abstract Update sql:
and add a test on alt_identifier to select only alternate identifier prefixed with "doi:" (cf VOResource 1.2, 2.2.5 Alternate Identifiers)
|
this commit also renames 'description' into 'abstract'
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
+ Coverage 66.52% 66.53% +0.01%
==========================================
Files 235 235
Lines 18101 18114 +13
==========================================
+ Hits 12041 12052 +11
- Misses 6060 6062 +2 ☔ View full report in Codecov by Sentry. |
Gilles remarks are now implemented. This made me realize that the doctests were skipped for I think it's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, pending a very minor docstring formatting issue. I'll go ahead and commit that directly and go ahead with the merge.
Also, I noticed that there is a new failure with the remote tests which is apparently unrelated and is due to changes in astropy, so will open a PR with the fix.
Thank you @ManonMarchand! |
Hello astroquery,
What the PR does
This PR adds a method to astroquery.vizier.VizierClass to retrieve metadata information for a given catalog. This should solve these issues :
How it's done
It's a TAP query sent to the ivoa registry with pyvo. The output is an astropy table.
Edit: This is in a draft state cause @gilleslandais will do a first review