Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reading partition info pixels from Norder/Npix #474

Merged
merged 3 commits into from
Mar 17, 2025

Conversation

delucchi-cmu
Copy link
Contributor

In preparation for removing the columns from default import. This is not necessary, and the strict argument only clutters things.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (86610eb) to head (91bccbf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   91.80%   92.29%   +0.48%     
==========================================
  Files          47       47              
  Lines        1978     1933      -45     
==========================================
- Hits         1816     1784      -32     
+ Misses        162      149      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 14, 2025

Before [86610eb] After [fe74856] Ratio Benchmark (Parameter)
72.4±0.3ms 72.8±0.3ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
73.1±0.7ms 73.0±0.3ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
12.2±0.4ms 12.2±0.3ms 1 benchmarks.Suite.time_inner_pixel_alignment
39.0±0.5ms 38.8±0.4ms 1 benchmarks.Suite.time_pixel_tree_creation
108±0.6ms 108±0.5ms 1 benchmarks.time_test_alignment_even_sky
1.03±0.02ms 1.03±0.02ms 1 benchmarks.time_test_cone_filter_multiple_order
18.9±0.1ms 18.7±0.1ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6
360±3ms 348±3ms 0.97 benchmarks.Suite.time_outer_pixel_alignment

Click here to view all benchmarks.

Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@delucchi-cmu delucchi-cmu merged commit 0887668 into main Mar 17, 2025
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/prefactor branch March 17, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants