Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered catalog should retain path. Add friendlier check for in-memo… #470

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

delucchi-cmu
Copy link
Contributor

The following scenario occured:

import lsdb
catalog = lsdb.read_hats(...)
catalog = catalog.cone_search(...)
catalog.aggregate_column_statistics()

This resulted in an error in the aggregate_column_statistics because the path became None during the geometric filter application.

@delucchi-cmu delucchi-cmu requested a review from camposandro March 7, 2025 20:42
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (a58935f) to head (ab67014).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   93.10%   93.11%   +0.01%     
==========================================
  Files          47       47              
  Lines        2044     2049       +5     
==========================================
+ Hits         1903     1908       +5     
  Misses        141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 7, 2025

Before [a58935f] After [a707a36] Ratio Benchmark (Parameter)
72.6±0.8ms 73.4±0.6ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
350±0.8ms 353±3ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
73.1±0.4ms 73.0±1ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
12.3±0.07ms 12.3±0.5ms 1 benchmarks.Suite.time_inner_pixel_alignment
106±0.5ms 106±1ms 1 benchmarks.time_test_alignment_even_sky
1.03±0.03ms 1.03±0.02ms 1 benchmarks.time_test_cone_filter_multiple_order
18.8±0.1ms 18.6±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6
39.2±0.2ms 38.9±0.8ms 0.99 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good!

@delucchi-cmu delucchi-cmu merged commit d689e8b into main Mar 7, 2025
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/filter_by_moc branch March 7, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants