Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always provide partitioning=None and filesystem #469

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

delucchi-cmu
Copy link
Contributor

This is part of the reason hats-cloudtests are failing this morning (another part is fixable within the hats-cloudtests repo).

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (f08cb51) to head (3d6b9cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hats/io/file_io/file_io.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   93.15%   93.10%   -0.05%     
==========================================
  Files          47       47              
  Lines        2044     2044              
==========================================
- Hits         1904     1903       -1     
- Misses        140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 6, 2025

Before [f08cb51] After [a9e040e] Ratio Benchmark (Parameter)
12.2±0.3ms 13.0±0.3ms 1.07 benchmarks.Suite.time_inner_pixel_alignment
18.5±0.06ms 18.8±0.07ms 1.02 benchmarks.MetadataSuite.time_load_partition_info_order6
72.7±0.5ms 73.6±0.3ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
72.7±0.5ms 73.1±0.3ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
355±3ms 353±1ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
39.4±0.6ms 39.1±0.8ms 0.99 benchmarks.Suite.time_pixel_tree_creation
106±0.6ms 105±1ms 0.99 benchmarks.time_test_alignment_even_sky
1.04±0.02ms 1.03±0.02ms 0.99 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested a review from hombit March 6, 2025 19:56
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for showing this code.

@delucchi-cmu delucchi-cmu merged commit a58935f into main Mar 6, 2025
10 of 12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/cloudtests branch March 6, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants