Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate test data, and update expectations. #467

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

delucchi-cmu
Copy link
Contributor

This change is not as big as it appears!

  • Add lines to the generate_data script to remove the catalogs before generating (see Avoid overwriting valid catalogs. hats-import#464)
  • Totally new margin results, based on sprint in November
  • schema is re-ordered, as we no longer write pandas metadata

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (12db6ea) to head (25cc6b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          47       47           
  Lines        2033     2033           
=======================================
  Hits         1895     1895           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 5, 2025

Before [12db6ea] After [2e36f6b] Ratio Benchmark (Parameter)
104±0.7ms 106±1ms 1.02 benchmarks.time_test_alignment_even_sky
351±0.9ms 354±1ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
1.04±0.02ms 1.06±0.04ms 1.01 benchmarks.time_test_cone_filter_multiple_order
39.1±0.6ms 39.2±0.8ms 1 benchmarks.Suite.time_pixel_tree_creation
12.4±0.4ms 12.0±0.3ms 0.97 benchmarks.Suite.time_inner_pixel_alignment
74.9±3ms 71.8±1ms 0.96 benchmarks.MetadataSuite.time_load_partition_info_order7
19.4±0.8ms 18.4±0.3ms 0.95 benchmarks.MetadataSuite.time_load_partition_info_order6
75.4±3ms 71.5±1ms 0.95 benchmarks.MetadataSuite.time_load_partition_join_info

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested a review from gitosaurus March 5, 2025 18:56
Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants