Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include model tags in parsers as well as a list parameter to filter them #69

Closed
wants to merge 1 commit into from

Conversation

chrishronek
Copy link
Contributor

@chrishronek chrishronek commented Dec 23, 2022

Please take a look at the issue I've attached. This will be a doozie - tags are just one selector type, but they feel the most applicable to our parsers.

In a dbt project, tags can be set in 3 places (see more info here):

  • a properties.yml file
  • a .sql file in the models directory
  • a dbt_project.yml file

(I've checked the ones that this PR would take care of) - the question is: Do we want to do it this way? This feels like the most natural, but we should talk about the following:

  • the other selector types besides tags (these may or may not apply to how the parsers are parsing)
    • path:
    • config:
    • test_type:
    • test_name:
  • whether this will be too strenuous on the DbtDag and DbtTaskGroup process to do this in-memory

@chrishronek chrishronek added enhancement New feature or request customer request An Astronomer customer made requested this labels Dec 23, 2022
@chrishronek chrishronek self-assigned this Dec 23, 2022
@chrishronek chrishronek linked an issue Dec 23, 2022 that may be closed by this pull request
@chrishronek chrishronek requested a review from a team December 23, 2022 05:41
@chrishronek
Copy link
Contributor Author

@jlaneve took a stab at the tags piece of selectors - not sure if this is how we wanted to do it, and it'd probably be best to discuss. I figured some of this (or all of it) would get implemented one way or another.

@chrishronek
Copy link
Contributor Author

Implemented in another PR

@chrishronek chrishronek deleted the parsers-selector-arg branch January 12, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer request An Astronomer customer made requested this enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Airflow DAG/Task Group from a dbt selector argument
1 participant