-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "Config" select/exclude to DbtDag & DbtTaskGroup parsers #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will convert the DbtModelConfig to this:
...as opposed to this:
which will really simplify the process for a customer when it comes to using jaffle_shop = DbtTaskGroup(
dbt_project_name="jaffle_shop",
conn_id="snowflake_chronek",
dbt_args={"dbt_executable_path": "/usr/local/airflow/dbt_venv/bin/dbt"},
test_behavior='after_all',
select={ #this could also be an exclude parameter with the same value for the opposite effect
"configs": ['schema:stg']
},
dag=dag,
) ...additionally, it will be easier for our parser to do a single |
jlaneve
reviewed
Feb 1, 2023
jlaneve
reviewed
Feb 1, 2023
jlaneve
reviewed
Feb 1, 2023
…-cosmos into config-selector-90
This reverts commit 7583fd8.
jlaneve
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 90
I added the label
bug
because I found syntax preventing tags from being read out ofproperties.yml
files correctly.