Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pydantic dependency #74

Closed
jlaneve opened this issue Jan 4, 2023 · 0 comments · Fixed by #77
Closed

Remove pydantic dependency #74

jlaneve opened this issue Jan 4, 2023 · 0 comments · Fixed by #77

Comments

@jlaneve
Copy link
Collaborator

jlaneve commented Jan 4, 2023

Right now, we require Pedantic because I used it for validation. However, it's one of 3 dependencies we have and we should try to remove it. Options seem to be:

  • use dataclasses
  • write validation/logic ourself
@jlaneve jlaneve mentioned this issue Jan 9, 2023
Merged
jlaneve added a commit that referenced this issue Jan 10, 2023
@jlaneve @chrishronek
Refactor to support new features and code maintainability (#77)
0abc67d 
This is a pretty large refactor of how we were doing parsing and
generation to support a few goals:
- General code maintainability and extensibility
- Subclass Airflow's DAG and TaskGroup model instead of returning them
- Remove `pydantic` dependency in favor of dataclasses (closes #74)
- Add different testing types (`after_each`, `after_all`, `none`)
(closes #62)
- Add tags support (from code and from yml config) (partially addresses
#67)
- Add docs for testing types and tags

Co-authored-by: Chris Hronek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to support new features and code maintainability astronomer/astronomer-cosmos
1 participant
@jlaneve