Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop catching generic Exception in triggerer #98

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Stop catching generic Exception in triggerer #98

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
555322d
Add TERMINAL_JOB_STATUSES
tatiana Nov 28, 2024
9aad4de
Stop catching generic `Exception` in triggerer
tatiana Nov 28, 2024
9eea5c6
Update tests/test_triggers.py
tatiana Nov 28, 2024
f0169f8
Update tests/test_triggers.py
tatiana Nov 28, 2024
8239cc6
Apply suggestions from code review
tatiana Nov 28, 2024
ccbca8c
Fix import position
tatiana Nov 28, 2024
1cdae2a
Fix issue in the CI
tatiana Nov 28, 2024
b236d81
Add blank line
tatiana Nov 28, 2024
2d7cdc2
Fix static checks
tatiana Nov 28, 2024
866cbc9
Fix static checks
tatiana Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix static checks
  • Loading branch information
@tatiana
tatiana committed Nov 28, 2024
commit 2d7cdc2a789e5a11da168322afdd9a745150fac6
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ build-whl: setup-dev ## Build installable whl file
# Delete any previous wheels, so different versions don't conflict
rm dev/include/*
cd dev
# delete potential previous versions, otherwise there will be a conflict
# during installation
rm include/*
python3 -m build --outdir dev/include/

.PHONY: docker-run
Expand Down
Loading