Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading Docs to GitHub Pages #28

Merged
merged 11 commits into from
Jun 27, 2024
Merged

Uploading Docs to GitHub Pages #28

merged 11 commits into from
Jun 27, 2024

Conversation

venkatajagannath
Copy link
Contributor

@venkatajagannath venkatajagannath commented Jun 24, 2024 •
edited
Loading

Screenshot 2024-06-27 at 6 02 36 AM
Screenshot 2024-06-27 at 6 03 26 AM
Screenshot 2024-06-27 at 6 04 23 AM

@venkatajagannath venkatajagannath changed the title Created docs.yml Uploading Docs to GitHub Pages Jun 24, 2024
@venkatajagannath venkatajagannath linked an issue Jun 24, 2024 that may be closed by this pull request
Documentation for Github pages #23
Closed
pankajastro
pankajastro reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs. Mostly looking good to me. I've added some comments; please let me know what you think. Also, could you please add some screenshots in the PR to show how this is rendering?

pankajastro
pankajastro previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@venkatajagannath venkatajagannath merged commit fe4b540 into main Jun 27, 2024
16 checks passed
@venkatajagannath venkatajagannath deleted the docs branch June 27, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajastro pankajastro pankajastro approved these changes

@schnie schnie Awaiting requested review from schnie schnie is a code owner

@tatiana tatiana Awaiting requested review from tatiana tatiana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for Github pages
2 participants
@venkatajagannath @pankajastro