Proof-of-concept for using simple-repository instead of the non-standards based JSON API #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ards based JSON API
pelson
commented
Sep 10, 2024
| @@ -31,11 +31,21 @@ This will start up a Flask app, and will print out a line such as:: | |||
|
|
|||
| You can then call pip with:: | |||
|
|
|||
| pip install --index-url http://127.0.0.1:5000/ astropy | |||
| pip install --index-url http://127.0.0.1:5000/simple/ astropy | |||
There was a problem hiding this comment.
Also caused by some inflexibility on simple-repository-server (at https://github.com/simple-repository/simple-repository-server/blob/main/simple_repository_server/routers/simple.py#L41).
There is no good reason for this limitation, but it would require some more thought than I have capacity for this evening 😴
pelson
commented
Nov 5, 2024
| @@ -40,43 +100,20 @@ def main(cutoff_date, port, quiet): | |||
|
|
|||
| CUTOFF = parse_iso(cutoff_date) | |||
|
|
|||
| INDEX = requests.get(MAIN_PYPI).content | |||
| repo = DateFilteredReleases( | |||
| HttpRepository(MAIN_PYPI), | |||
There was a problem hiding this comment.
Forgot to say: There is no real reason not to parameterise this now... it is something that has been asked for to support private indexes. (e.g. https://www.reddit.com/r/Python/comments/1cte019/comment/l4bh02p/ #8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 @astrofrog (long time no see... hope you're doing well!)
I have been working on providing package repository infrastructure at work, and have built up a set of libraries that make building custom repositories child's play 😜. In fact, I thought I would test it out on your awesome
pypi-timemachine, and include my <30min hack in this PR. The result is a fully functional prototype (though I was disappointed with the fact that implementing #7 wasn't so easy due to some inflexibility in thesimple-repository-serverrouter definition - I will refine that 😉)A huge advantage of the approach taken in this PR is that you no longer rely on the (original and non-standardised) JSON API, and instead are using the PEP-503++ goodness that is out there on PyPI already.
I doubt you actually want to merge this (just yet at least) - the
simple-repositorycodebase is still in preview / not-yet-maintained stage, and I would be fine if you want to go ahead and close the PR without merge.