Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit: additional check for aggregation module parameter #80

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Audit: additional check for aggregation module parameter #80

merged 5 commits into from
Jul 16, 2024

Conversation

JordyRo1
Copy link
Contributor

Best practice

  • Add a check at the constructor level to make sure that the module length is lower than 255, to avoid overflow on the verify function.

@JordyRo1 JordyRo1 requested a review from EvolveArt July 10, 2024 16:51
@EvolveArt EvolveArt merged commit 484fe5e into main Jul 16, 2024
4 checks passed
@EvolveArt EvolveArt deleted the Audit-Aggregation-ISM-module-number-check branch July 16, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvolveArt EvolveArt EvolveArt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordyRo1 @EvolveArt