Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace logs to is_extended_transient_error #9248

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 19, 2024

No description provided.

@zanieb zanieb force-pushed the zb/trace-is_extended_transient_error branch from 862e738 to e846b7b Compare November 19, 2024 21:26
@zanieb
Copy link
Member Author

zanieb commented Nov 19, 2024

@charliermarsh still sort of into the idea of adding something like this, though we might need to include the error in the message.

@charliermarsh
Copy link
Member

I can take over if you want, makes sense.

@zanieb
Copy link
Member Author

zanieb commented Nov 19, 2024

All yours! I figure you have a better setup to test what's helpful here.

@charliermarsh charliermarsh force-pushed the zb/trace-is_extended_transient_error branch from e091d7c to 57a6f20 Compare November 19, 2024 22:52
@charliermarsh charliermarsh marked this pull request as ready for review November 19, 2024 22:52
@charliermarsh
Copy link
Member

Does this look ok?

@charliermarsh charliermarsh force-pushed the zb/trace-is_extended_transient_error branch from 57a6f20 to 80bd731 Compare November 19, 2024 22:56
@charliermarsh charliermarsh merged commit 7c4c15b into main Nov 20, 2024
64 checks passed
@charliermarsh charliermarsh deleted the zb/trace-is_extended_transient_error branch November 20, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracing Verbose output and debugging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants