Improve static metadata extraction for Poetry projects #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/err
branch
from
482dbcd to
021f040
Compare
charliermarsh
force-pushed
the
charlie/err
branch
from
021f040 to
b4a0583
Compare
konstin
approved these changes
Jun 10, 2024
Comment on lines
+215
to
+217
| // If dependencies are declared with Poetry, and `project.dependencies` is omitted, treat | ||
| // the dependencies as dynamic. The inclusion of a `project` table without defining | ||
| // `project.dependencies` is almost certainly an error. |
There was a problem hiding this comment.
We should warn, that's a spec violation
There was a problem hiding this comment.
It's a spec violation in Poetry, right? What the user wrote is totally fine.
There was a problem hiding this comment.
Merging for now but will follow-up based on your reply.
There was a problem hiding this comment.
We should warn because using poetry <2 and [project] together without setting dynamic has unintended consequences, either on their own is technically compliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds handling for a few cases to improve interoperability with Poetry:
projectschema is invalid, we now raise a hard error, rather than treating the metadata as dynamic and then falling back to the build backend. This could cause problems, I'm not sure. It's stricter than before.tool.poetrybut omitsproject.dependencies, we now treat it as dynamic. We could go even further and treat any Poetry project as dynamic, but then we'd be ignoring user-declared dependencies, which is also confusing.Closes #4142.