Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use union of requires-python in workspace #4041

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Jun 5, 2024

Follow-up to #4016.

This exposes Range and PubGrubSpecifier from outside the resolver to use pubgrub's union creating a dependency edge we don't really want.

@konstin konstin added the preview Experimental behavior label Jun 5, 2024
konstin added 4 commits June 6, 2024 08:22
When creating a lockfile, lock the combined dependencies for all packages in a workspace. This make the lockfile independent of where you are in the workspace.

Fixes #3983
@konstin konstin force-pushed the konsti/lock-all-packages-in-workspace branch from 4794cd6 to bbfa5f4 Compare June 6, 2024 09:27
@konstin konstin force-pushed the konsti/version-union branch from 66cea11 to c065006 Compare June 6, 2024 10:07
@konstin konstin force-pushed the konsti/version-union branch from c065006 to ed7136e Compare June 6, 2024 12:40
@konstin konstin marked this pull request as ready for review June 6, 2024 14:31
Base automatically changed from konsti/lock-all-packages-in-workspace to main June 6, 2024 19:09
@charliermarsh
Copy link
Member

@konstin -- let's look for a way to remove exposing PubGrub here... I can try it.

@charliermarsh charliermarsh enabled auto-merge (squash) June 6, 2024 19:18
@charliermarsh charliermarsh merged commit e4e2590 into main Jun 6, 2024
45 checks passed
@charliermarsh charliermarsh deleted the konsti/version-union branch June 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants