Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable uv lock from pip interface #3970

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

I think we can start using uv lock and uv sync to test this instead.

@charliermarsh charliermarsh added the preview Experimental behavior label Jun 3, 2024
@charliermarsh charliermarsh marked this pull request as ready for review June 3, 2024 00:12
@charliermarsh charliermarsh force-pushed the charlie/unstable branch 2 times, most recently from ea90020 to 06a96c5 Compare June 3, 2024 00:23
@charliermarsh charliermarsh requested a review from BurntSushi June 3, 2024 00:25
Copy link

codspeed-hq bot commented Jun 3, 2024

CodSpeed Performance Report

Merging #3970 will not alter performance

Comparing charlie/unstable (9aba38d) with main (fbf562d)

Summary

✅ 13 untouched benchmarks

@charliermarsh charliermarsh force-pushed the charlie/glob branch 3 times, most recently from 07d3df7 to 61c9d70 Compare June 3, 2024 01:25
Base automatically changed from charlie/glob to main June 3, 2024 01:33
@BurntSushi
Copy link
Member

BurntSushi commented Jun 3, 2024

The PR itself looks good. I think one remaining thing here (because I just tried it) is specifying the index URL. I can do that with uv pip compile, but I'm not sure how to do that with uv lock yet. We need to be able to specify an index URL for packse tests.

BurntSushi added a commit that referenced this pull request Jun 3, 2024
Otherwise the `uv lock` command wasn't respecting the index URL option.

This is a follow-up to #3984, and I believe should now allow #3970 to be
merged.
BurntSushi added a commit that referenced this pull request Jun 3, 2024
Otherwise the `uv lock` command wasn't respecting the index URL option.

This is a follow-up to #3984, and I believe should now allow #3970 to be
merged.
BurntSushi added a commit that referenced this pull request Jun 3, 2024
Otherwise the `uv lock` command wasn't respecting the index URL option.

This is a follow-up to #3984, and I believe should now allow #3970 to be
merged.
BurntSushi added a commit that referenced this pull request Jun 3, 2024
Otherwise the `uv lock` command wasn't respecting the index URL option.

This is a follow-up to #3984, and I believe should now allow #3970 to be
merged.
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I can run packse tests on the universal resolver without the use of --unstable-uv-lock-file, so this should be good to go. 👍 Thank you!

@charliermarsh charliermarsh enabled auto-merge (squash) June 3, 2024 14:58
@charliermarsh charliermarsh merged commit 650638f into main Jun 3, 2024
46 checks passed
@charliermarsh charliermarsh deleted the charlie/unstable branch June 3, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants