Add local path conversions from lockfile #3609
Conversation
| let path_dist = PathSourceDist { | ||
| name: self.id.name.clone(), | ||
| url: VerbatimUrl::from_url(self.id.source.url.clone()), | ||
| path: self.id.source.url.to_file_path().unwrap(), |
There was a problem hiding this comment.
It's a bit strange that we require both url and path, but I think the intent is that we do this fallible conversion when constructing to the type so that we don't have to do it everywhere that we need the path.
There was a problem hiding this comment.
Yeah that makes sense I think.
(I am fond of the idea of encapsulating the distribution types and defining constructors for them. That way, you can add derived fields or whatever else without much fuss. But that's a big refactor and I am not altogether offended by pure data structs. They have their advantages...)
charliermarsh
force-pushed
the
charlie/dir-lock
branch
from
52857cc to
aa9cca6
Compare
charliermarsh
force-pushed
the
charlie/dir-lock
branch
from
aa9cca6 to
288f51c
Compare
| let path_dist = PathSourceDist { | ||
| name: self.id.name.clone(), | ||
| url: VerbatimUrl::from_url(self.id.source.url.clone()), | ||
| path: self.id.source.url.to_file_path().unwrap(), |
There was a problem hiding this comment.
Yeah that makes sense I think.
(I am fond of the idea of encapsulating the distribution types and defining constructors for them. That way, you can add derived fields or whatever else without much fuss. But that's a big refactor and I am not altogether offended by pure data structs. They have their advantages...)
Summary
Just does the most basic thing to convert from
Distributionback to the installable type.