Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the cache-dependency-glob default to **/uv.lock #77

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

eifinger
Copy link
Collaborator

@eifinger eifinger commented Sep 16, 2024

We should aim for a solution with sane defaults that work as most users would expect it.

The current default leads to a cache that is never invalidated and thus never updated.

This also mirrors the default behaviors for setup-python which use **/requirements.txt, **/Pipfile.lock or **/poetry.lock

The uv cache on the filesystem can be uploaded to the GitHub Actions cache, but they are distinct things.

Also make it clear that the local cache path can be changed without using `enable-cache: true`
@eifinger eifinger added documentation Improvements or additions to documentation breaking-change labels Sep 16, 2024
@eifinger eifinger force-pushed the default-cache-dependency-glob branch from 0e41a15 to e3dd1bc Compare September 16, 2024 13:39
@eifinger eifinger changed the title Set the cache-dependency-glob default to **uv.lock Set the cache-dependency-glob default to **/uv.lock Sep 16, 2024
This mirrors the default behavior for setup-python
Adding the path separator `/` makes sure the files get found no matter where they are in the repo.
@eifinger eifinger force-pushed the default-cache-dependency-glob branch from e3dd1bc to 47f1355 Compare September 16, 2024 13:45
README.md Outdated

### Local cache path

This action controls where `uv` stores its cache on the runner's filesystem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This action controls where `uv` stores its cache on the runner's filesystem.
This action controls where uv stores its cache on the runner's filesystem.

We don't stylize the name as code :)

@eifinger eifinger merged commit 8d65000 into main Sep 16, 2024
37 checks passed
@eifinger eifinger deleted the default-cache-dependency-glob branch September 16, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants